nickuncaged1201 commented on code in PR #27039:
URL: https://github.com/apache/beam/pull/27039#discussion_r1231554292
##########
sdks/java/io/file-schema-transform/src/main/java/org/apache/beam/sdk/io/fileschematransform/JsonWriteSchemaTransformFormatProvider.java:
##########
@@ -51,22 +60,33 @@ public String identifier() {
* {@link PCollection} file names written using {@link TextIO.Write}.
*/
@Override
- public PTransform<PCollection<Row>, PCollection<String>> buildTransform(
+ public PTransform<PCollection<Row>, PCollectionTuple> buildTransform(
Review Comment:
Done
##########
sdks/java/io/file-schema-transform/src/main/java/org/apache/beam/sdk/io/fileschematransform/FileWriteSchemaTransformProvider.java:
##########
@@ -129,7 +136,11 @@ public PCollectionRowTuple expand(PCollectionRowTuple
input) {
.build()))
.setRowSchema(OUTPUT_SCHEMA);
- return PCollectionRowTuple.of(OUTPUT_TAG, output);
+ if (files.has(ERROR_TAG)) {
+ return PCollectionRowTuple.of(OUTPUT_TAG, output).and("error",
files.get(ERROR_TAG));
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
