tvalentyn commented on code in PR #25965:
URL: https://github.com/apache/beam/pull/25965#discussion_r1237607711
##########
sdks/python/apache_beam/examples/complete/game/user_score.py:
##########
@@ -177,12 +178,20 @@ def format_user_score_sums(user_score):
(user, score) = user_score
return 'user: %s, total_score: %s' % (user, score)
- ( # pylint: disable=expression-not-assigned
- p
- | 'ReadInputText' >> beam.io.ReadFromText(args.input)
- | 'UserScore' >> UserScore()
- | 'FormatUserScoreSums' >> beam.Map(format_user_score_sums)
- | 'WriteUserScoreSums' >> beam.io.WriteToText(args.output))
+ try:
Review Comment:
I am hoping that this is no longer necessary, but if it were necessary, i'd
expect to have reasons in the PR description. I am sure this was discussed in
PR review somewhere, but comments are hard to dig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
