ahmedabu98 commented on code in PR #27413:
URL: https://github.com/apache/beam/pull/27413#discussion_r1263908171
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProtoTest.java:
##########
@@ -1049,6 +1050,58 @@ public void testIntegerTypeConversion() throws
DescriptorValidationException {
}
}
+ @Test
+ public void testTimestampTypeConversion() throws
DescriptorValidationException {
Review Comment:
sorry got busy with other things
> I think the test needed for this fix is the Timestamp input value bounds
test.
you're right this case is specific to an upper bound, but i think it still
fits in a parsing test. thanks for adding it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
