ahmedabu98 commented on code in PR #27413:
URL: https://github.com/apache/beam/pull/27413#discussion_r1259863280
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProtoTest.java:
##########
@@ -1049,6 +1050,58 @@ public void testIntegerTypeConversion() throws
DescriptorValidationException {
}
}
+ @Test
+ public void testTimestampTypeConversion() throws
DescriptorValidationException {
Review Comment:
This is not a blocker, but for completeness can you add this case
(`"9999-12-31...'") as a new field in the general test cases in this file (e.g.
`BASE_TABLE_SCHEMA_PROTO`)?
You can look at https://github.com/apache/beam/pull/26879/files for an
example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
