jrmccluskey commented on code in PR #27536: URL: https://github.com/apache/beam/pull/27536#discussion_r1267089228
########## sdks/python/container/base_image_requirements_manual.txt: ########## @@ -25,9 +25,7 @@ # Consider constraining requirements of Beam itself when necessary. bs4 # Commonly used HTML processing tool. -# Don't upgrade to Cython 3.x, until it's released, stable and we have consensus -# to upgrade. Use 0.xx for now. -cython<1 +cython<4 Review Comment: The code change that needs to happen for cython 3.0.0 to be happy is still compatible with 0.29.x so we should be good, but I'm definitely in favor of going with the fixed bound instead of < 4. ########## sdks/python/setup.py: ########## @@ -110,7 +110,7 @@ def get_version(): # `pipenv` package managers. pass -REQUIRED_CYTHON_VERSION = '0.28.1' +REQUIRED_CYTHON_VERSION = '3.0.0' Review Comment: Going with 3.0.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
