tvalentyn commented on code in PR #27536:
URL: https://github.com/apache/beam/pull/27536#discussion_r1267273865
##########
.github/workflows/build_wheels.yml:
##########
@@ -269,7 +269,7 @@ jobs:
# TODO: https://github.com/apache/beam/issues/23048
CIBW_SKIP: "*-musllinux_*"
CIBW_ENVIRONMENT: "SETUPTOOLS_USE_DISTUTILS=stdlib"
- CIBW_BEFORE_BUILD: pip install cython==0.29.36 numpy && pip install
--upgrade setuptools
+ CIBW_BEFORE_BUILD: pip install cython==3.0.0 numpy && pip install
--upgrade setuptools
Review Comment:
This line is what will cause most change to users: we will now build beam
wheels with Cython 3.0.
1) Honestly, I would sit on Cython 3.0 for a bit and see what issues are
reported, if any. I don't mind using Cython 3.0 in tests asap.
2) I suggest we merge this as soon as 2.50.0 is cut, that would give us ~6
weeks buffer time. Let's cut an issue blocking 2.51.0 to revisit that we are
still ok with shipping wheels built on Cython 3. Alternative: submit now, but
revert this for the 2.50.0 release branch.
3) Let's announce in CHANGES.md: Beam wheels are now built with Cython 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
