tvalentyn commented on code in PR #27716:
URL: https://github.com/apache/beam/pull/27716#discussion_r1276694204
##########
sdks/go/container/build.gradle:
##########
@@ -38,8 +41,10 @@ docker {
files "./build/"
buildArgs(['pull_licenses':
project.rootProject.hasProperty(["docker-pull-licenses"]) ||
project.rootProject.hasProperty(["isRelease"])])
- buildx project.containerPlatforms() != [project.nativeArchitecture()]
+ buildx useBuildx
platform(*project.containerPlatforms())
+ load useBuildx && !pushContainers
Review Comment:
I am not sure how useful it is to keep the image designed for a different
platform. we should test and see that all layers (incl base) would be selected
for the target platform after such loading + manual push to a different repo.
##########
build.gradle.kts:
##########
@@ -440,10 +440,6 @@ tasks.register("goPortablePreCommit") {
dependsOn(":sdks:go:test:ulrValidatesRunner")
}
-tasks.register("goPostCommitDataflowARM") {
Review Comment:
I think i suggested to remove it before offline, but feel free to keep this,
looks like it's a convention that other `go` tests follow even if there is
dependency only on one target.
##########
sdks/go/test/run_validatesrunner_tests.sh:
##########
@@ -430,8 +424,7 @@ echo ">>> RUNNING $RUNNER integration tests with pipeline
options: $ARGS"
cd ../..
if [[ "$RUNNER" == "dataflow" ]]; then
- # Delete the container locally and remotely
- docker rmi $CONTAINER:$TAG || echo "Failed to remove container"
+ # Delete the container remotely
Review Comment:
we could still try delete locally as best effort, if that would help non-arm
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
