tvalentyn commented on code in PR #27716:
URL: https://github.com/apache/beam/pull/27716#discussion_r1276771968
##########
sdks/go/test/run_validatesrunner_tests.sh:
##########
@@ -430,8 +424,7 @@ echo ">>> RUNNING $RUNNER integration tests with pipeline
options: $ARGS"
cd ../..
if [[ "$RUNNER" == "dataflow" ]]; then
- # Delete the container locally and remotely
- docker rmi $CONTAINER:$TAG || echo "Failed to remove container"
+ # Delete the container remotely
Review Comment:
that is what should be happening. There is an OR (||), so the command
shouldn't fail, only error message should be shown. We could adjust the error
message text though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
