saavannanavati commented on a change in pull request #12352:
URL: https://github.com/apache/beam/pull/12352#discussion_r465302751
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -520,10 +520,26 @@ def run(self, test_runner_api='AUTO'):
self._options,
allow_proto_holders=True).run(False)
+ if (self._options.view_as(TypeOptions).runtime_type_check and
+ self._options.view_as(TypeOptions).performance_runtime_type_check):
+ raise RuntimeError(
Review comment:
I don't see a use case. The existing `runtime_type_check` flag does
everything that `performance_runtime_type_check` does but more, since it
runtime type-checks everything instead of sampling. If a user turns on both,
they lose performance in 2 ways with no added benefit coming from the
`performance_runtime_type_check`. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
