aromanenko-dev commented on code in PR #27851:
URL: https://github.com/apache/beam/pull/27851#discussion_r1286030184
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/ConvertHelpers.java:
##########
@@ -86,10 +85,11 @@ public static <T> ConvertedSchemaInformation<T>
getConvertedSchemaInformation(
// output.
convertedSchema =
new ConvertedSchemaInformation<>((SchemaCoder<T>)
SchemaCoder.of(inputSchema), null);
- } else if (outputType.equals(TypeDescriptor.of(GenericRecord.class))) {
- convertedSchema =
- new ConvertedSchemaInformation<T>(
- (SchemaCoder<T>)
AvroUtils.schemaCoder(AvroUtils.toAvroSchema(inputSchema)), null);
+ // } else if
(outputType.equals(TypeDescriptor.of(GenericRecord.class))) {
Review Comment:
I temporary commented this "if" case but I'm stuck on how to properly handle
this without adding a dependency on Avro extension or copying the needed code
and keeps Avro dependency.
@mosche Do you have any idea on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
