mosche commented on code in PR #27851:
URL: https://github.com/apache/beam/pull/27851#discussion_r1286283729
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/ConvertHelpers.java:
##########
@@ -86,10 +85,11 @@ public static <T> ConvertedSchemaInformation<T>
getConvertedSchemaInformation(
// output.
convertedSchema =
new ConvertedSchemaInformation<>((SchemaCoder<T>)
SchemaCoder.of(inputSchema), null);
- } else if (outputType.equals(TypeDescriptor.of(GenericRecord.class))) {
- convertedSchema =
- new ConvertedSchemaInformation<T>(
- (SchemaCoder<T>)
AvroUtils.schemaCoder(AvroUtils.toAvroSchema(inputSchema)), null);
+ // } else if
(outputType.equals(TypeDescriptor.of(GenericRecord.class))) {
Review Comment:
@aromanenko-dev The only possible way I see to decouple this is to use an
AutoService with a provider and a provider registrar as done in many different
places, e.g. SchemaProvider and SchemaProviderRegistrar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
