volatilemolotov commented on code in PR #27923:
URL: https://github.com/apache/beam/pull/27923#discussion_r1288736922


##########
.github/actions/setup-action/action.yml:
##########
@@ -57,3 +57,8 @@ runs:
         github_repository: ${{ github.repository }}     
         github_current_run_id: ${{ github.run_id }}
         pull_request_url: ${{ github.event.issue.pull_request.url }}
+    ### Used for Flink jobs that call docker run and mount gcloud folder

Review Comment:
   We decided to put it there as to hide the implementation from the people 
creating new workflows. 
   Its not necessarily just for Flink but other jobs could use gcloud. 
   
   Its not compute intensive so really not an issue to keep it there



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to