Abacn commented on code in PR #27923:
URL: https://github.com/apache/beam/pull/27923#discussion_r1288756229
##########
.github/actions/setup-action/action.yml:
##########
@@ -57,3 +57,8 @@ runs:
github_repository: ${{ github.repository }}
github_current_run_id: ${{ github.run_id }}
pull_request_url: ${{ github.event.issue.pull_request.url }}
+ ### Used for Flink jobs that call docker run and mount gcloud folder
Review Comment:
Thanks! sounds good
> Its not necessarily just for Flink but other jobs could use gcloud.
Probably change the comment for clarity?
The cause is that `action/checkout` adds a post-job step to the workflow. If
`action/checkout` is added to custom action (`setup-action`) and the PR changed
the yml of `setup-action`, it fails during this post-job step because the
setup-action.yml gets overwritten.
I did not find a way to fix either, other than testing on fork with master
branch also updated. In general we should not need to change setup-action.yml
frequently once it's stabilized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
