Abacn commented on code in PR #28007:
URL: https://github.com/apache/beam/pull/28007#discussion_r1295294400
##########
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BigQueryTableProviderTest.java:
##########
@@ -67,7 +67,7 @@ public void testDefaultMethod_whenPropertiesAreNotSet() {
public void testSelectDefaultMethodExplicitly() {
Table table =
fakeTableWithProperties(
- "hello", "{ " + METHOD_PROPERTY + ": " + "\"" +
Method.DEFAULT.toString() + "\" }");
+ "hello", "{\"" + METHOD_PROPERTY + "\": " + "\"" +
Method.DEFAULT.toString() + "\" }");
Review Comment:
there are multiple changes of adding quotes here. Do they mean a breaking
change (SQL statements worked before now need to add quotes) / is there any
chance keep the original semantics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
