Abacn commented on PR #28007:
URL: https://github.com/apache/beam/pull/28007#issuecomment-1681002476

   There are test failures:
   
   ```
   
org.apache.beam.sdk.extensions.sql.meta.provider.kafka.KafkaTableProviderIT.testFake2[0]
   
   Error Message
   java.lang.RuntimeException: illegal table properties: { "format" : "json",}
        at 
org.apache.beam.sdk.extensions.sql.TableUtils.parseProperties(TableUtils.java:50)
        at 
org.apache.beam.sdk.extensions.sql.meta.provider.kafka.KafkaTableProviderIT.testFake2(KafkaTableProviderIT.java:156)
   ...
   ```
   
   Previously a ill-formed json `{ "format" : "json",}` works, now it does not. 
   
   Similarly, it is nice to tolerant trailing comma


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to