TobKed commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r465774681
##########
File path: sdks/python/apache_beam/runners/worker/log_handler_test.py
##########
@@ -87,7 +87,8 @@ def _verify_fn_log_handler(self, num_log_entries):
self.assertEqual(
'%s: %s' % (msg, num_received_log_entries), log_entry.message)
self.assertTrue(
- re.match(r'.*/log_handler_test.py:\d+', log_entry.log_location),
+ re.match(
+ r'.*(/|\\)log_handler_test.py:\d+', log_entry.log_location),
Review comment:
I used `rf'.*{os.sep}log_handler_test.py:\d+'` but it caused:
```
2020-08-05T14:25:17.1905260Z > raise source.error("bad
escape %s" % escape, len(escape))
2020-08-05T14:25:17.1905424Z E sre_constants.error: bad
escape \l at position 2
```
https://github.com/apache/beam/pull/12452/checks?check_run_id=949595653
I reverted change.
Should I use it somehow differently?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
