TheNeuralBit commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r466635592
##########
File path: sdks/python/apache_beam/testing/datatype_inference_test.py
##########
@@ -174,6 +175,7 @@ def test_infer_typehints_schema(self, _, data, schema):
@parameterized.expand([(d["name"], d["data"], d["pyarrow_schema"])
for d in TEST_DATA])
@unittest.skipIf(pa is None, "PyArrow is not installed")
+ @unittest.skipIf(sys.platform == "win32", "[BEAM-10624]")
Review comment:
Looks like it's not actually related to pyarrow version. I think we
should fix it by making the dtype explicit for the numpy arrays created here:
https://github.com/apache/beam/blob/8d03dc698dcea1745a26c9823c8d942f5634c6b1/sdks/python/apache_beam/testing/datatype_inference_test.py#L57
I have a personal Windows machine I could clone Beam on and verify, but it
might be simpler to just test the fix as part of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
