johnjcasey commented on code in PR #28032:
URL: https://github.com/apache/beam/pull/28032#discussion_r1296280323
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java:
##########
@@ -302,15 +303,15 @@ public void testWriteDynamicDestinations() throws
Exception {
}
@Test
- public void testWriteDynamicDestinationsBatchWithSchemas() throws Exception {
- writeDynamicDestinations(true, false);
+ public void testWriteDynamicDestinationsWithAutoSharding() throws Exception {
+ assumeTrue(useStreaming);
+ assumeTrue(!useStorageApiApproximate); // STORAGE_API_AT_LEAST_ONCE
ignores auto-sharding
+ writeDynamicDestinations(false, false);
}
@Test
- public void testWriteDynamicDestinationsStreamingWithAutoSharding() throws
Exception {
- assumeTrue(useStreaming);
- assumeTrue(!useStorageApiApproximate); // STORAGE_API_AT_LEAST_ONCE
ignores auto-sharding
- writeDynamicDestinations(true, true);
+ public void testWriteDynamicDestinationsWithBeamSchemas() throws Exception {
Review Comment:
Why did we change the name of this?
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java:
##########
@@ -1329,8 +1330,12 @@ static class SchemaPojo {
}
@Test
- public void testSchemaWriteLoads() throws Exception {
- assumeTrue(!useStreaming);
+ public void testBatchSchemaWriteLoads() throws Exception {
+ // This test is actually for batch!
+ // We just invert useStreaming because we need it as true to test
+ // STORAGE_API_AT_LEAST_ONCE,
+ assumeTrue(useStreaming);
Review Comment:
It looks like you don't invert useStreaming, is that intentional?
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java:
##########
@@ -302,15 +303,15 @@ public void testWriteDynamicDestinations() throws
Exception {
}
@Test
- public void testWriteDynamicDestinationsBatchWithSchemas() throws Exception {
- writeDynamicDestinations(true, false);
+ public void testWriteDynamicDestinationsWithAutoSharding() throws Exception {
+ assumeTrue(useStreaming);
+ assumeTrue(!useStorageApiApproximate); // STORAGE_API_AT_LEAST_ONCE
ignores auto-sharding
+ writeDynamicDestinations(false, false);
Review Comment:
Why did we swap this from true, true to false, false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
