ahmedabu98 commented on code in PR #28032:
URL: https://github.com/apache/beam/pull/28032#discussion_r1296311554
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java:
##########
@@ -302,15 +303,15 @@ public void testWriteDynamicDestinations() throws
Exception {
}
@Test
- public void testWriteDynamicDestinationsBatchWithSchemas() throws Exception {
- writeDynamicDestinations(true, false);
+ public void testWriteDynamicDestinationsWithAutoSharding() throws Exception {
+ assumeTrue(useStreaming);
+ assumeTrue(!useStorageApiApproximate); // STORAGE_API_AT_LEAST_ONCE
ignores auto-sharding
+ writeDynamicDestinations(false, false);
}
@Test
- public void testWriteDynamicDestinationsStreamingWithAutoSharding() throws
Exception {
- assumeTrue(useStreaming);
- assumeTrue(!useStorageApiApproximate); // STORAGE_API_AT_LEAST_ONCE
ignores auto-sharding
- writeDynamicDestinations(true, true);
+ public void testWriteDynamicDestinationsWithBeamSchemas() throws Exception {
Review Comment:
To be more accurate:
1. This tests both batch and streaming modes
2. `withSchemas` actually means using with Beam Schema
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java:
##########
@@ -302,15 +303,15 @@ public void testWriteDynamicDestinations() throws
Exception {
}
@Test
- public void testWriteDynamicDestinationsBatchWithSchemas() throws Exception {
- writeDynamicDestinations(true, false);
+ public void testWriteDynamicDestinationsWithAutoSharding() throws Exception {
+ assumeTrue(useStreaming);
+ assumeTrue(!useStorageApiApproximate); // STORAGE_API_AT_LEAST_ONCE
ignores auto-sharding
+ writeDynamicDestinations(false, false);
Review Comment:
Good catch, this was unintended. Will revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
