slilichenko commented on code in PR #28171:
URL: https://github.com/apache/beam/pull/28171#discussion_r1307654053
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillStateInternals.java:
##########
@@ -970,9 +972,7 @@ public TimestampedValueWithId<T> next() {
Iterables.mergeSorted(
ImmutableList.of(data, pendingInRange),
TimestampedValueWithId.COMPARATOR);
Iterable<TimestampedValue<T>> fullIterable =
- Iterables.filter(
- Iterables.transform(includingAdds,
TimestampedValueWithId::getValue),
- tv -> !pendingDeletes.contains(tv.getTimestamp()));
+ Iterables.transform(includingAdds,
TimestampedValueWithId::getValue);
Review Comment:
The last delete will win because of the filter clause at 950 and the last
insert will win because of the transform that will merge the add at 975?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
