reuvenlax commented on code in PR #28171:
URL: https://github.com/apache/beam/pull/28171#discussion_r1309707455
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WindmillStateInternalsTest.java:
##########
@@ -2169,6 +2169,71 @@ public void testOrderedListMergePendingAdds() {
assertArrayEquals(expected, read);
}
+ @Test
+ public void testOrderedListMergePendingAddsAndDeletes() {
+ SettableFuture<Map<Range<Instant>, RangeSet<Long>>> orderedListFuture =
SettableFuture.create();
+ orderedListFuture.set(null);
+ SettableFuture<Map<Range<Instant>, RangeSet<Instant>>> deletionsFuture =
+ SettableFuture.create();
+ deletionsFuture.set(null);
+ when(mockReader.valueFuture(
+ systemKey(NAMESPACE, "orderedList" + IdTracker.IDS_AVAILABLE_STR),
+ STATE_FAMILY,
+ IdTracker.IDS_AVAILABLE_CODER))
+ .thenReturn(orderedListFuture);
+ when(mockReader.valueFuture(
+ systemKey(NAMESPACE, "orderedList" + IdTracker.DELETIONS_STR),
+ STATE_FAMILY,
+ IdTracker.SUBRANGE_DELETIONS_CODER))
+ .thenReturn(deletionsFuture);
+
+ SettableFuture<Iterable<TimestampedValue<String>>> fromStorage =
SettableFuture.create();
+ when(mockReader.orderedListFuture(
+ FULL_ORDERED_LIST_RANGE,
+ key(NAMESPACE, "orderedList"),
+ STATE_FAMILY,
+ StringUtf8Coder.of()))
+ .thenReturn(fromStorage);
+
+ StateTag<OrderedListState<String>> addr =
+ StateTags.orderedList("orderedList", StringUtf8Coder.of());
+ OrderedListState<String> orderedListState = underTest.state(NAMESPACE,
addr);
+
+ orderedListState.add(TimestampedValue.of("second",
Instant.ofEpochMilli(1)));
+ orderedListState.add(TimestampedValue.of("third",
Instant.ofEpochMilli(2)));
+ orderedListState.add(TimestampedValue.of("fourth",
Instant.ofEpochMilli(2)));
Review Comment:
no - I delete it and then add it back with a different ts (though one still
within the deletion range)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
