AyWa commented on code in PR #28068:
URL: https://github.com/apache/beam/pull/28068#discussion_r1314098221
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPortableClientEntryPoint.java:
##########
@@ -73,28 +79,41 @@
public class FlinkPortableClientEntryPoint {
private static final Logger LOG =
LoggerFactory.getLogger(FlinkPortableClientEntryPoint.class);
private static final String JOB_ENDPOINT_FLAG = "--job_endpoint";
- private static final Duration JOB_INVOCATION_TIMEOUT =
Duration.ofSeconds(30);
- private static final Duration JOB_SERVICE_STARTUP_TIMEOUT =
Duration.ofSeconds(30);
+ // TODO: add environments variable or parameters
+ private static final Duration JOB_INVOCATION_TIMEOUT =
Duration.ofSeconds(90);
Review Comment:
I had some problem with the 30 second timeout in my test k8s cluster.
Should I put that in the cli option ?
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPortableClientEntryPoint.java:
##########
@@ -73,28 +79,41 @@
public class FlinkPortableClientEntryPoint {
private static final Logger LOG =
LoggerFactory.getLogger(FlinkPortableClientEntryPoint.class);
private static final String JOB_ENDPOINT_FLAG = "--job_endpoint";
- private static final Duration JOB_INVOCATION_TIMEOUT =
Duration.ofSeconds(30);
- private static final Duration JOB_SERVICE_STARTUP_TIMEOUT =
Duration.ofSeconds(30);
+ // TODO: add environments variable or parameters
+ private static final Duration JOB_INVOCATION_TIMEOUT =
Duration.ofSeconds(90);
+ private static final Duration JOB_SERVICE_STARTUP_TIMEOUT =
Duration.ofSeconds(90);
private final String driverCmd;
+ private final String artifactStagingPath;
+ private final boolean cleanArtifactsPerJob;
private FlinkJobServerDriver jobServer;
private Thread jobServerThread;
private DetachedJobInvokerFactory jobInvokerFactory;
private int jobPort = 0; // pick any free port
- public FlinkPortableClientEntryPoint(String driverCmd) {
+ public FlinkPortableClientEntryPoint(String driverCmd, String
artifactStagingPath,
Review Comment:
okay let me try to do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
