Abacn commented on code in PR #28068:
URL: https://github.com/apache/beam/pull/28068#discussion_r1317418819
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPortableClientEntryPoint.java:
##########
@@ -73,28 +79,41 @@
public class FlinkPortableClientEntryPoint {
private static final Logger LOG =
LoggerFactory.getLogger(FlinkPortableClientEntryPoint.class);
private static final String JOB_ENDPOINT_FLAG = "--job_endpoint";
- private static final Duration JOB_INVOCATION_TIMEOUT =
Duration.ofSeconds(30);
- private static final Duration JOB_SERVICE_STARTUP_TIMEOUT =
Duration.ofSeconds(30);
+ // TODO: add environments variable or parameters
+ private static final Duration JOB_INVOCATION_TIMEOUT =
Duration.ofSeconds(90);
Review Comment:
yeah, please, there is no harm to do that - and better keep the default
setting as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
