piotr-szuberski commented on a change in pull request #12422:
URL: https://github.com/apache/beam/pull/12422#discussion_r466629615
##########
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/BasicKinesisProvider.java
##########
@@ -39,16 +40,27 @@
private final String secretKey;
private final Regions region;
private final @Nullable String serviceEndpoint;
+ private final boolean verifyCertificate;
BasicKinesisProvider(
- String accessKey, String secretKey, Regions region, @Nullable String
serviceEndpoint) {
+ String accessKey,
+ String secretKey,
+ Regions region,
+ @Nullable String serviceEndpoint,
+ boolean verifyCertificate) {
checkArgument(accessKey != null, "accessKey can not be null");
checkArgument(secretKey != null, "secretKey can not be null");
checkArgument(region != null, "region can not be null");
this.accessKey = accessKey;
this.secretKey = secretKey;
this.region = region;
this.serviceEndpoint = serviceEndpoint;
+ this.verifyCertificate = verifyCertificate;
+ }
+
+ BasicKinesisProvider(
Review comment:
When you use KinesisIO.write()..withAWSClientsProvider("accesskey",
"secretkey", "region", "serviceEndpointUrl") then without my modification beam
will try to use real AWS url instead of the given "serviceEndpointUrl". I don't
think this is the desired behaviour, but correct me if I'm wrong or I don't
understand something (which is very probable, I haven't used AWS much in my
life).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
