piotr-szuberski commented on a change in pull request #12422: URL: https://github.com/apache/beam/pull/12422#discussion_r467962690
########## File path: sdks/java/io/kinesis/src/test/java/org/apache/beam/sdk/io/kinesis/KinesisIOIT.java ########## @@ -35,33 +42,51 @@ import org.apache.beam.sdk.values.PCollection; import org.joda.time.Duration; import org.joda.time.Instant; +import org.junit.AfterClass; import org.junit.BeforeClass; import org.junit.Rule; import org.junit.Test; import org.junit.runner.RunWith; import org.junit.runners.JUnit4; +import org.testcontainers.containers.localstack.LocalStackContainer; /** * Integration test, that writes and reads data to and from real Kinesis. You need to provide {@link - * KinesisTestOptions} in order to run this. + * KinesisTestOptions} in order to run this if you want to test it with production setup. By default + * when no options are provided an instance of localstack is used. */ @RunWith(JUnit4.class) public class KinesisIOIT implements Serializable { - private static int numberOfShards; - private static int numberOfRows; + private static final String LOCALSTACK_VERSION = "0.11.3"; Review comment: Not at all. 0.11.3 is the latest localstack image available on Dockerhub. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org