ahmedabu98 commented on PR #28264: URL: https://github.com/apache/beam/pull/28264#issuecomment-1726370765
Got it, I'll remove the `crashSink` option from TestProperties so that it's not exposed to the performance testing framework. I'll still include the crashing logic. We can later create a test that makes use of this same class by just passing `crashStorageApiSinkEverySeconds=<seconds>" to pipeline options. If this option is set, the test will run the pipelines normally without publishing any metrics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
