johnjcasey commented on code in PR #28264:
URL: https://github.com/apache/beam/pull/28264#discussion_r1336008504
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -3266,6 +3268,8 @@ && getStorageApiTriggeringFrequency(bqOptions) != null) {
checkArgument(
!getAutoSchemaUpdate(),
"withAutoSchemaUpdate only supported when using STORAGE_WRITE_API
or STORAGE_API_AT_LEAST_ONCE.");
+ } else if (getWriteDisposition() == WriteDisposition.WRITE_TRUNCATE) {
Review Comment:
We should probably log this as an error. If we could make breaking changes,
I would fail submission here.
In general, a user specifying a configuration that doesn't actually do the
thing they would expect is not good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
