chamikaramj commented on code in PR #28540:
URL: https://github.com/apache/beam/pull/28540#discussion_r1330695769
##########
sdks/python/apache_beam/transforms/external.py:
##########
@@ -414,7 +414,7 @@ def __init__(
def expand(self, pcolls):
# Expand the transform using the expansion service.
- return pcolls | ExternalTransform(
+ return pcolls | self._payload_builder._identifier >> ExternalTransform(
Review Comment:
Do possible characters and format for payload builder identifier and
PTransform labels match ?
##########
sdks/python/apache_beam/transforms/external.py:
##########
@@ -414,7 +414,7 @@ def __init__(
def expand(self, pcolls):
# Expand the transform using the expansion service.
- return pcolls | ExternalTransform(
+ return pcolls | self._payload_builder._identifier >> ExternalTransform(
Review Comment:
Let's not use private variable "_identifier" here. (either use something
else or add a public property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
