[GitHub] [beam] ahmedabu98 commented on a diff in pull request #28540: Label Python external SchemaTransform with its URN

Tue, 19 Sep 2023 14:17:13 -0700 


ahmedabu98 commented on code in PR #28540:
URL: https://github.com/apache/beam/pull/28540#discussion_r1330710410


##########
sdks/python/apache_beam/transforms/external.py:
##########
@@ -414,7 +414,7 @@ def __init__(
 
   def expand(self, pcolls):
     # Expand the transform using the expansion service.
-    return pcolls | ExternalTransform(
+    return pcolls | self._payload_builder._identifier >> ExternalTransform(

Review Comment:
   I can't find documentation on what the standard is for PTransform labels, 
but I tried the Storage API xlang wrapper with URN 
`beam:schematransform:org.apache.beam:bigquery_storage_write:v2` and it shows 
up fine on the Dataflow DAG: 
   
![image](https://github.com/apache/beam/assets/65791736/52121e1c-c51d-41c4-9fda-280757b67813)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to