kennknowles commented on code in PR #28272:
URL: https://github.com/apache/beam/pull/28272#discussion_r1337495113
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteTables.java:
##########
@@ -251,7 +253,10 @@ public void processElement(
List<String> partitionFiles =
Lists.newArrayList(element.getValue().getFilenames());
String jobIdPrefix =
BigQueryResourceNaming.createJobIdWithDestination(
- c.sideInput(loadJobIdPrefixView), tableDestination, partition,
c.pane().getIndex());
+ c.sideInput(loadJobIdPrefixView),
+ tableDestination,
+ partition,
+ element.getValue().getPaneIndex());
Review Comment:
My concern is that if we have this:
GBK -> processing -> reshuffle -> this DoFn
Can you tell me which case we are in?
1. The `processing` left the key the same so the reshuffle is just for
checkpoint
2. The `processing` changed the key so that the current element key + pane
index is no longer unique
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
