Abacn commented on code in PR #28272:
URL: https://github.com/apache/beam/pull/28272#discussion_r1337563554
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteTables.java:
##########
@@ -251,7 +253,10 @@ public void processElement(
List<String> partitionFiles =
Lists.newArrayList(element.getValue().getFilenames());
String jobIdPrefix =
BigQueryResourceNaming.createJobIdWithDestination(
- c.sideInput(loadJobIdPrefixView), tableDestination, partition,
c.pane().getIndex());
+ c.sideInput(loadJobIdPrefixView),
+ tableDestination,
+ partition,
+ element.getValue().getPaneIndex());
Review Comment:
Well it's a little bit more subtle. It is the same key, but became
ShardedKey after `processing`
After GBK, key is DestinationT
After processing, key is ShardedKey<DestinationT> (shard is added in
WritePartitions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
