baeminbo commented on code in PR #28548:
URL: https://github.com/apache/beam/pull/28548#discussion_r1337975910
##########
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java:
##########
@@ -288,6 +288,15 @@ private void init(
residualElementsList == null
? new ResidualElements(Collections.emptyList())
: new ResidualElements(residualElementsList);
+
+ if (this.residualSource != null) {
Review Comment:
Yes, it's at [Reader.getCheckpointMark()](
https://github.com/apache/beam/blob/204c69721a8d5ef98423ff03bea0b6ab90b10dc3/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java#L385).
The `getCheckpointMark()` is called at bundle finish in Dataflow streaming
jobs, and `close()` will be pending as readers are cached. A reader can be
reused in next bundles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
