Abacn commented on code in PR #28726:
URL: https://github.com/apache/beam/pull/28726#discussion_r1340781777
##########
sdks/java/testing/jpms-tests/build.gradle:
##########
@@ -21,7 +21,14 @@ import groovy.json.JsonOutput
plugins {
id 'org.apache.beam.module'
}
-javaVersion="1.11"
+
+// overwrite javaVersion before applyJavaNature
+if (project.hasProperty("compileAndRunTestsWithJava17")) {
+ javaVersion = '1.17'
+} else {
+ javaVersion = '1.11'
Review Comment:
this is subtle. Current Java11/Java17 test are configured differently.
- Java11 passed `-Dorg.gradle.java.home=$JAVA_HOME_11_X64` so all projects
(e.g. java core) are also compared with Java11
- Java17 uses `compileAndRunTestsWithJava17` flag so all but this project
are compiled with default JDK (Java8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
