Abacn commented on code in PR #28726:
URL: https://github.com/apache/beam/pull/28726#discussion_r1341469501
##########
sdks/java/testing/jpms-tests/build.gradle:
##########
@@ -33,30 +40,15 @@ enableJavaPerformanceTesting()
description = "Apache Beam :: SDKs :: Java :: Testing :: JPMS Tests"
ext.summary = "E2E test for Java 9 modules"
-// Java 17 needs compileJava to add-exports and add-opens for error prone
-if (project.hasProperty("compileAndRunTestsWithJava17")) {
- def java17Home = project.findProperty("java17Home")
- project.tasks.withType(JavaCompile) {
+// direct compileJava to use specified java version.
+project.tasks.compileJava {
Review Comment:
We do not have `setJava11Options` or correspondents in beamModulePlugin
setJava17Options is due to new module export rules needed in Java17
(https://blogs.oracle.com/javamagazine/post/a-peek-into-java-17-continuing-the-drive-to-encapsulate-the-java-runtime-internals),
it does the same thing as the current code (removed/simplified in this PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
