tvalentyn commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r467345624
##########
File path: sdks/python/apache_beam/typehints/typecheck_test_py3.py
##########
@@ -92,23 +93,29 @@ def test_wrapper_pass_through(self):
# We use a file to check the result because the MyDoFn instance passed is
# not the same one that actually runs in the pipeline (it is serialized
# here and deserialized in the worker).
- with tempfile.NamedTemporaryFile(mode='w+t') as f:
- dofn = MyDoFn(f.name)
+
+ fd, path = tempfile.mkstemp()
+ try:
+ os.close(fd)
Review comment:
The reference to JIRA in #12452 (comment) was that you could make test
changes in a separate commit such as:
`[BEAM-123456] Fix tests that don't pass on Windows`
and have another commit:
`[BEAM-10623] Add workflow to run Beam python tests on Linux/Windows/Mac
platforms`.
In this case the reason behind not obvious code would be easier to infer
from commit history.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
