damccorm commented on code in PR #28777:
URL: https://github.com/apache/beam/pull/28777#discussion_r1345728443
##########
examples/notebooks/beam-ml/automatic_model_refresh.ipynb:
##########
@@ -132,8 +119,6 @@
"from typing import Tuple\n",
"\n",
"import apache_beam as beam\n",
- "from apache_beam.examples.inference.tensorflow_imagenet_segmentation
import PostProcessor\n",
- "from apache_beam.examples.inference.tensorflow_imagenet_segmentation
import read_image\n",
Review Comment:
We still need to inline this function somewhere (probably alongside the
mapping function where we call it)
##########
examples/notebooks/beam-ml/automatic_model_refresh.ipynb:
##########
@@ -99,27 +99,14 @@
},
{
"cell_type": "code",
- "execution_count": null,
+ "execution_count": 3,
"metadata": {
- "id": "1RyTYsFEIOlA",
- "outputId": "0e6b88a7-82d8-4d94-951c-046a9b8b7abb",
- "colab": {
- "base_uri": "https://localhost:8080/";
- }
+ "id": "1RyTYsFEIOlA"
},
- "outputs": [
- {
- "output_type": "stream",
- "name": "stdout",
- "text": [
- "\n"
- ]
- }
- ],
+ "outputs": [],
"source": [
"!pip install apache_beam[gcp]>=2.46.0 --quiet\n",
- "!pip install tensorflow\n",
- "!pip install tensorflow_hub"
+ "# !pip install tensorflow_hub"
Review Comment:
Did you mean to change these locally?
##########
examples/notebooks/beam-ml/automatic_model_refresh.ipynb:
##########
@@ -224,29 +202,13 @@
"\n",
"# The Dataflow temp location. This location is used to store
temporary files or intermediate results before outputting to the sink.\n",
"options.view_as(GoogleCloudOptions).temp_location = '%s/temp' %
dataflow_gcs_location\n",
- "\n",
- "options.view_as(SetupOptions).save_main_session = True\n",
- "\n",
- "# Launching Dataflow with only one worker might result in processing
delays due to\n",
- "# initial input processing. This could further postpone the side
input model updates.\n",
- "# To expedite the model update process, it's recommended to set
num_workers>1.\n",
- "# https://github.com/apache/beam/issues/28776\n";,
- "options.view_as(WorkerOptions).num_workers = 5"
+ "\n"
Review Comment:
Did you mean to remove save_main_session/num_workers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
