tvalentyn commented on code in PR #28946:
URL: https://github.com/apache/beam/pull/28946#discussion_r1357225166
##########
sdks/python/apache_beam/pipeline.py:
##########
@@ -1353,18 +1353,28 @@ def transform_to_runner_api(
environment_id = context.get_environment_id_for_resource_hints(
self.resource_hints)
+ inputs = {
Review Comment:
> p | beam.WindowInto(...) should also be an error right there (checked in
WindowInto's expand method).
+1 to Robert's comment, moving this validation inside `WindowInto` methods
would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
