Abacn commented on code in PR #29015:
URL: https://github.com/apache/beam/pull/29015#discussion_r1361108187
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -134,6 +134,12 @@ public PCollection<Row> expand(PBegin input) {
if (partitions != null) {
readRows = readRows.withNumPartitions(partitions);
}
+
+ @Nullable Short fetchSize = config.getInt16("fetchSize");
Review Comment:
This would result in the same limit as
https://github.com/apache/beam/pull/28999 as int64_max=32767. This may or may
not be a reason why https://github.com/apache/beam/pull/12498/files set this to
int16 at the first place. We may revisit this if there is use case that need to
make fetch size larger. Currently better document the max allowed number is
int16_max here
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -134,6 +134,12 @@ public PCollection<Row> expand(PBegin input) {
if (partitions != null) {
readRows = readRows.withNumPartitions(partitions);
}
+
+ @Nullable Short fetchSize = config.getInt16("fetchSize");
Review Comment:
This would result in the same limit as
https://github.com/apache/beam/pull/28999 as int16_max=32767. This may or may
not be a reason why https://github.com/apache/beam/pull/12498/files set this to
int16 at the first place. We may revisit this if there is use case that need to
make fetch size larger. Currently better document the max allowed number is
int16_max here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
