Abacn commented on code in PR #29015:
URL: https://github.com/apache/beam/pull/29015#discussion_r1362258682
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -134,6 +134,12 @@ public PCollection<Row> expand(PBegin input) {
if (partitions != null) {
readRows = readRows.withNumPartitions(partitions);
}
+
+ @Nullable Short fetchSize = config.getInt16("fetchSize");
Review Comment:
this would change existing behavior. If change the default we should switch
the int16 to int32 type for fetchSize everywhere (SchemaIOProvider, Python
wrapper) to give an option for user to keep the original size (50,000). Current
change also LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
