johnjcasey commented on code in PR #29114:
URL: https://github.com/apache/beam/pull/29114#discussion_r1370418741
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -2143,6 +2144,8 @@ public static <T> Write<T> write() {
.setMaxRetryJobs(1000)
.setPropagateSuccessfulStorageApiWrites(false)
.setDirectWriteProtos(true)
+ .setDefaultMissingValueInterpretation(
+ AppendRowsRequest.MissingValueInterpretation.DEFAULT_VALUE)
Review Comment:
I just want to double check we aren't breaking backwards compatability
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -2143,6 +2144,8 @@ public static <T> Write<T> write() {
.setMaxRetryJobs(1000)
.setPropagateSuccessfulStorageApiWrites(false)
.setDirectWriteProtos(true)
+ .setDefaultMissingValueInterpretation(
+ AppendRowsRequest.MissingValueInterpretation.DEFAULT_VALUE)
Review Comment:
Is DEFAULT_VALUE our current default, or do we default to null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
