reuvenlax commented on code in PR #29114:
URL: https://github.com/apache/beam/pull/29114#discussion_r1370804678
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -2143,6 +2144,8 @@ public static <T> Write<T> write() {
.setMaxRetryJobs(1000)
.setPropagateSuccessfulStorageApiWrites(false)
.setDirectWriteProtos(true)
+ .setDefaultMissingValueInterpretation(
+ AppendRowsRequest.MissingValueInterpretation.DEFAULT_VALUE)
Review Comment:
Yeah - the BigQuery sink didn't really support default values before, so I
consider the previous behavior as accidental, undefined behavior. Doesn't mean
that customers didn't rely on it, but I'm ok with changing it especially since
we're still providing a way to default to null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
