boyuanzz commented on a change in pull request #12531:
URL: https://github.com/apache/beam/pull/12531#discussion_r468822213
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -647,7 +647,7 @@ def set(self, ts):
windows=(self._window, ),
clear_bit=False,
fire_timestamp=ts,
- hold_timestamp=self._input_timestamp,
+ hold_timestamp=ts,
Review comment:
Can we only use fire_timestamp as hold_timestamp when in event time
domain?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
