mxm commented on a change in pull request #12531:
URL: https://github.com/apache/beam/pull/12531#discussion_r469068866
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -647,7 +647,7 @@ def set(self, ts):
windows=(self._window, ),
clear_bit=False,
fire_timestamp=ts,
- hold_timestamp=self._input_timestamp,
+ hold_timestamp=ts,
Review comment:
Do you mean to keep the input timestamp if we have a processing time
timer?
As far as I'm concerned, the hold/output timestamp is only relevant for
event time timers. Processing timers do not operate in event time and thus do
not respect this timestamp, no matter what it is set to. Unless there is a good
reason for introducing this conditional behavior, I'd keep it as-is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
