m-trieu commented on PR #29082: URL: https://github.com/apache/beam/pull/29082#issuecomment-1787975271
> Latest changes don't appear to have been pushed BTW if fixups to PR are kept as separate commits (instead of squashed and force pushing) I think that Github review tool may work better. It seems easy to squash when merging so I don't think there should be concerns about those commits making it to beam/master branch. sgtm i think i got confused about the recommendations :) will keep them at seperate commits from now on -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
