scwhittle commented on code in PR #29082:
URL: https://github.com/apache/beam/pull/29082#discussion_r1384853430
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ActiveWorkState.java:
##########
@@ -83,6 +85,33 @@ static ActiveWorkState forTesting(
return new ActiveWorkState(activeWork, computationStateCache);
}
+ private static Stream<KeyedGetDataRequest> toKeyedGetDataRequests(
+ ShardedKey shardedKey, Collection<Work> workQueue, Instant
refreshDeadline) {
+ return workQueue.stream()
+ .filter(work -> work.getStartTime().isBefore(refreshDeadline))
+ .map(
+ work ->
+ Windmill.KeyedGetDataRequest.newBuilder()
+ .setKey(shardedKey.key())
Review Comment:
can rm the key, sharding key is sufficient and cheaper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
