JayajP commented on code in PR #29098:
URL: https://github.com/apache/beam/pull/29098#discussion_r1387065406
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiFinalizeWritesDoFn.java:
##########
@@ -126,6 +140,12 @@ public void process(PipelineOptions pipelineOptions,
@Element KV<String, String>
rowsFinalized.inc(response.getRowCount());
finalizeOperationsSucceeded.inc();
+ BigQuerySinkMetrics.FinalizeStreamCounter("ok").inc();
+ @Nullable Instant operationStartTime = c.getOperationStartTime();
+ Instant operationEndTime = Instant.now();
+ BigQuerySinkMetrics.UpdateRpcLatencyMetric(
Review Comment:
This is clearer with the new method to update RpcRequests and RpcLatency
metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
