JayajP commented on code in PR #29098:
URL: https://github.com/apache/beam/pull/29098#discussion_r1387078339
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java:
##########
@@ -643,11 +650,20 @@ long flush(
contexts -> {
AppendRowsContext failedContext =
Preconditions.checkStateNotNull(Iterables.getFirst(contexts,
null));
+ Instant operationEndTime = Instant.now();
Review Comment:
Repacked updating the `RpcRequests` and `RpcLatency` metrics into utility
methods since that are reused across all write methods. These updates are now
handled by `reportSuccessfulRpcMetrics` and `reportFailedRPCMetrics`.
It's not straightforward to refactor updates `AppendRowsRowStatus` into a
utility. When we update this metric we need to know the number of rows that
were failed/retried/succeeded so it's more embedded in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
