Abacn commented on code in PR #29419:
URL: https://github.com/apache/beam/pull/29419#discussion_r1396539134
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamDockerPlugin.groovy:
##########
@@ -267,7 +272,19 @@ class BeamDockerPlugin implements Plugin<Project> {
if (ext.pull) {
buildCommandLine.add '--pull'
}
- buildCommandLine.addAll(['-t', "${-> ext.name}", '.'])
+ if (!ext.tags.isEmpty() && ext.push) {
Review Comment:
BeamDockerPlugin is vendored due to that the plugin we used stopped support
Java8. There is still hope we can unvendor if beam build on Java11+ and change
to this file will make it out-of-sync. Is there a possibility make multiarch
working without the need of modify the plugin? It might do because currently we
do push multiarch container to gcr.io for some tests (e.g. ARM PostCommit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
