Abacn commented on code in PR #29419:
URL: https://github.com/apache/beam/pull/29419#discussion_r1396541306
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamDockerPlugin.groovy:
##########
@@ -267,7 +272,19 @@ class BeamDockerPlugin implements Plugin<Project> {
if (ext.pull) {
buildCommandLine.add '--pull'
}
- buildCommandLine.addAll(['-t', "${-> ext.name}", '.'])
+ if (!ext.tags.isEmpty() && ext.push) {
Review Comment:
I see, it's because the need to attach with multiple tag names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
