aromanenko-dev commented on code in PR #29390:
URL: https://github.com/apache/beam/pull/29390#discussion_r1397584006
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/AvroGenericRecordToStorageApiProtoTest.java:
##########
@@ -301,7 +301,7 @@ enum TestEnum {
.set(
"decimalValue",
new Conversions.DecimalConversion()
- .toBytes(bd, Schema.create(Schema.Type.NULL),
LogicalTypes.decimal(1, 1)))
+ .toBytes(bd, Schema.create(Schema.Type.NULL),
LogicalTypes.decimal(2, 1)))
Review Comment:
Why it was changed?
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/AvroGenericRecordToStorageApiProto.java:
##########
@@ -262,8 +262,7 @@ private static TableFieldSchema
fieldDescriptorFromAvroField(Schema.Field field)
elementType.getType() != Schema.Type.UNION,
"Multiple non-null union types are not supported.");
TableFieldSchema unionFieldSchema =
- fieldDescriptorFromAvroField(
- new Schema.Field(field.name(), elementType, field.doc(),
field.defaultVal()));
+ fieldDescriptorFromAvroField(new Schema.Field(field.name(),
elementType, field.doc()));
Review Comment:
Is it going to be compiled successfully with previous Avro versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
